Integration Test for Hash commands #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anishkoulgi please fix lint issue |
anishkoulgi
force-pushed
the
feat/hash-commands-integration-tests
branch
from
7fac486 to
98f18f0
Compare
|
@lucifercr07 fixed the lint issue. |
lucifercr07
requested changes
Oct 9, 2024
There was a problem hiding this comment.
LGTM, @anishkoulgi thanks for contributing. Minor comments.
Added testcases for testing: - Set simple key value pairs in the hash. - Update one key and set a new key. - Pass invalid number of arguments. - Pass invalid key.
Added testcases for testing: - HGET with a non-existent key. - HGET with a valid field in the key. - HGET with an invalid field in the key. - HGET with an invalid key.
Added testcases for testing: - HGETALL with a non-existent key. - HGETALL with a valid key. - HGETALL with an invalid key.
anishkoulgi
force-pushed
the
feat/hash-commands-integration-tests
branch
from
98f18f0 to
e8f54fe
Compare
|
@lucifercr07 addressed the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31
Here, we add the
testcontainers-gopackage to run integrations tests with a running dice server. All the commands are executed in the dice container. The container is shared by all commands tests and cleaned up after all the tests have finished running.Tests for following commands have been added in
internal/tests/integration/commands:HGETHSETHGETALLNote
As of creating this PR, the
dicedb/dicedb:latestimage does not have theHINCRBYandHMGETcommands implemented. Hence, the tests for these commands have not been added in this PR. We will create a separate issue for these commands.